Fix a bug that prevented #pretty_print from displaying records unsaved in collection association. #48653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in collection association. The change in PR rails#43302 introduced a bug where unsaved records are not displayed in pretty_print. The following code will not show unsaved records until this PR is merged. ```ruby post = Post.create! post.comments.build pp(post.comments) #=> expected "[#<Post:0x000000014c0b48a0 ...>]", got "[]" ``` Fixed to call `#load_target` before display as well as `#inspect`.
alpaca-tc
force-pushed
the
fix-association-pretty-print
branch
from
ad2ad28
to
4c245bf
Compare
kamipo
added a commit
that referenced
this pull request
Sep 4, 2023
Fix a bug that prevented #pretty_print from displaying records unsaved in collection association.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The change in PR #43302 introduced a bug where unsaved records are not displayed in pretty_print. The following code will not show unsaved records until this PR is merged.
Detail
Fixed to call
#load_targetbefore display as well as#inspect.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]